test: add coverage for autobutcher, misery, seedwatch, logistics, suspendmanager - #5928
Open
Alistair-Afton wants to merge 1 commit into
Open
Alistair-Afton wants to merge 1 commit into
Alistair-Afton wants to merge 1 commit into
Conversation
…pendmanager Exercise plugin command parsing, config read/write paths, and overlay state logic in-engine. Tests that mutate state (seed targets, stockpile configs, job suspend flags, onStateChange hooks) snapshot and restore it in wrappers so the fort is left untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds in-engine test files for five plugins that previously had no coverage:
all/newkeywords, and every invalid-input path (targetcounts, missing races, unrecognized commands).status/clear/factor setters via the CLI path, factor below-minimum rejection, and status output text.all/single-plant targets,clear, fractional target flooring, unknown plant names, and missing/negative target rejection.enable/disable autoretrainroundtrip, unknown feature rejection,add/clearstockpile configs on a real stockpile, totals accounting ingetStockpileData, andnow(guarded so it only runs when no configs can designate items).foreach_construction_jobandrunOnce/unsuspend_commandunsuspension against a real constructed building,isBuildingPlanJob/isKeptSuspended, and theSuspendOverlaybuilding-tracking/viewport logic plus the no-selection paths of the status/toggle overlays.All state-mutating tests snapshot and restore in
config.wrapperfinalizers (seed targets, stockpile configs, job suspend flags,dfhack.onStateChangehooks, constructed buildings).Test plan
test -t plugins/autobutcher,plugins/misery,plugins/seedwatch,plugins/logistics,plugins/suspendmanager: 47/47 tests, 227/227 checks pass